Skip to content

fix: restore ARGUS feed route aliases#46

Open
QRcode1337 wants to merge 1 commit into
masterfrom
fix/feed-route-consistency
Open

fix: restore ARGUS feed route aliases#46
QRcode1337 wants to merge 1 commit into
masterfrom
fix/feed-route-consistency

Conversation

@QRcode1337

Copy link
Copy Markdown
Owner

Summary

  • Adds compatibility routes for /api/feeds/adsb, /api/feeds/ais, and /api/feeds/tle so health/feed route naming stays consistent.
  • Reduces AISStream default request timeout from 40s to 12s to avoid long external hangs.
  • Returns degraded AIS JSON when AISSTREAM_API_KEY is missing instead of HTTP 500.

Test Plan

  • Targeted ESLint on changed feed route files: passed.
  • npm run build: passed; verified build output includes /api/feeds/adsb, /api/feeds/ais, and /api/feeds/tle.
  • Local production server smoke test on :3211:
    • /api/feeds/adsb -> HTTP 200
    • /api/feeds/ais -> HTTP 200 degraded JSON without AISSTREAM_API_KEY
    • /api/feeds/tle -> HTTP 200
    • /api/feeds/aisstream -> HTTP 200 degraded JSON without AISSTREAM_API_KEY

Notes

  • Full npm run lint currently fails on pre-existing unrelated lint errors across ARGUS master; changed files pass targeted lint.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
argus dd82f15 Jun 08 2026, 01:04 AM

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
argus-app Error Error Jun 8, 2026 1:06am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd82f1579f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return NextResponse.json({ error: "AISSTREAM_API_KEY not configured" }, { status: 500 });
const message = "AISSTREAM_API_KEY not configured";
reportFeedHealth("aisstream", "error", message);
return NextResponse.json({ vessels: [], _degraded: true, _source: "ais-empty", _reason: message });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve AIS missing-key failure semantics

When AISSTREAM_API_KEY is unset, this now returns HTTP 200 with an empty vessels array even though the server records an error. The existing client only throws on non-OK responses in argus-app/src/lib/ingest/aisstream.ts:23-25, so the polling path in CesiumGlobe.tsx:1783-1786 will treat the missing credential as a successful AIS refresh and mark the feed healthy with zero vessels. Please keep a non-2xx status here or update the client to treat _degraded as a feed error/degraded state.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant